echauchot commented on code in PR #39:
URL:
https://github.com/apache/flink-connector-cassandra/pull/39#discussion_r2425938985
##########
flink-connector-cassandra/src/test/java/org/apache/flink/connector/cassandra/table/CassandraDynamicTableSourceITCase.java:
##########
@@ -45,12 +45,12 @@
@ExtendWith(MiniClusterExtension.class)
class CassandraDynamicTableSourceITCase {
- private CassandraTestEnvironment cassandraTestEnvironment;
- private StreamTableEnvironment tableEnv;
+ private static final CassandraTestEnvironment cassandraTestEnvironment =
+ new CassandraTestEnvironment(false);
+ private static StreamTableEnvironment tableEnv;
- @BeforeEach
- void setUp() throws Exception {
- cassandraTestEnvironment = new CassandraTestEnvironment(false);
+ @BeforeAll
Review Comment:
I just tested that @TestInstance(TestInstance.Lifecycle.PER_CLASS) works. If
you prefer non-static fields/methods. Fair enough. I updated the PR and
squashed review commit into relevant commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
