yuxiqian commented on code in PR #4150:
URL: https://github.com/apache/flink-cdc/pull/4150#discussion_r2426058263
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-iceberg/src/main/java/org/apache/flink/cdc/connectors/iceberg/sink/v2/IcebergSink.java:
##########
@@ -136,7 +140,7 @@ public void addPostCommitTopology(
// Shuffle by different table id.
DataStream<CommittableMessage<WriteResultWrapper>> keyedStream =
committableMessageDataStream.partitionCustom(
- (bucket, numPartitions) -> bucket % numPartitions,
+ this::partitionCustom,
Review Comment:
Can we just write `Math::floorMod` here?
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-iceberg/src/main/java/org/apache/flink/cdc/connectors/iceberg/sink/IcebergDataSinkFactory.java:
##########
@@ -122,6 +122,7 @@ public Set<ConfigOption<?>> optionalOptions() {
options.add(IcebergDataSinkOptions.PARTITION_KEY);
options.add(IcebergDataSinkOptions.SINK_COMPACTION_ENABLED);
options.add(IcebergDataSinkOptions.SINK_COMPACTION_COMMIT_INTERVAL);
+ options.add(IcebergDataSinkOptions.SINK_COMPACTION_PARALLELISM);
Review Comment:
Seems we're lacking a test case to cover all supported options in
`IcebergDataSinkFactoryTest`. Would you like to add one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
