ctrlaltdilj commented on code in PR #27026: URL: https://github.com/apache/flink/pull/27026#discussion_r2441559883
########## flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/model/FlinkPartETag.java: ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.fs.s3.common.model; + +import org.apache.flink.annotation.Internal; + +import java.io.Serializable; +import java.util.Objects; + +/** + * SDK-agnostic representation of a part uploaded in a multipart upload. + * + * <p>This class maintains compatibility with both AWS SDK v1 {@code PartETag} and AWS SDK v2 {@code + * CompletedPart}, allowing the base S3 filesystem implementation to work with either SDK version. + * + * <p>This class is serializable to support checkpoint recovery. The serialization format is + * independent of any AWS SDK version, ensuring backward compatibility across SDK upgrades. + */ +@Internal +public final class FlinkPartETag implements Serializable { Review Comment: The S3 model abstraction was to keep the `flink-s3-fs-presto` and `flink-s3-fs-hadoop` smaller and compact so the presto dependency is not shipped with AWS SDK V2 as it does not no support it yet I can remove it, if its okay for AWS SDK V2 to be included with the presto dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
