rkhachatryan commented on code in PR #27070:
URL: https://github.com/apache/flink/pull/27070#discussion_r2440433457
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java:
##########
@@ -883,6 +935,43 @@ public enum RetryStrategy {
FIXED_DELAY
}
+ /** SinkUpsertMaterializer strategy. */
+ @PublicEvolving
+ public enum SinkUpsertMaterializeStrategy {
+ /**
+ * Simple implementation based on {@code ValueState<List>} (the
original implementation).
+ *
+ * <ul>
+ * <li>optimal for cases with history under approx. 100 elements
+ * <li>limited TTL support (per key granularity, i.e. no expiration
for old history
+ * elements)
+ * </ul>
+ */
+ LEGACY,
+ /**
+ * OrderedMultiSetState-based implementation based on a combination of
several MapState
+ * maintaining ordering and fast lookup properties.
+ *
+ * <ul>
+ * <li>faster and more memory-efficient on long histories
+ * <li>slower on short histories
+ * <li>currently, no TTL support (to be added in the future)
+ * <li>requires more space
+ * </ul>
+ */
+ MAP,
+ /**
+ * Similar to LEGACY, but compatible with MAP and therefore allows to
switch to ADAPTIVE.
+ */
Review Comment:
Yes.
And as of now, only `ADAPTIVE` supports switching internally.
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java:
##########
@@ -883,6 +935,43 @@ public enum RetryStrategy {
FIXED_DELAY
}
+ /** SinkUpsertMaterializer strategy. */
+ @PublicEvolving
+ public enum SinkUpsertMaterializeStrategy {
+ /**
+ * Simple implementation based on {@code ValueState<List>} (the
original implementation).
+ *
+ * <ul>
+ * <li>optimal for cases with history under approx. 100 elements
+ * <li>limited TTL support (per key granularity, i.e. no expiration
for old history
+ * elements)
+ * </ul>
+ */
+ LEGACY,
+ /**
+ * OrderedMultiSetState-based implementation based on a combination of
several MapState
+ * maintaining ordering and fast lookup properties.
+ *
+ * <ul>
+ * <li>faster and more memory-efficient on long histories
+ * <li>slower on short histories
+ * <li>currently, no TTL support (to be added in the future)
+ * <li>requires more space
+ * </ul>
+ */
+ MAP,
+ /**
+ * Similar to LEGACY, but compatible with MAP and therefore allows to
switch to ADAPTIVE.
+ */
Review Comment:
Right.
And as of now, only `ADAPTIVE` supports switching internally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
