snuyanzin commented on code in PR #27096:
URL: https://github.com/apache/flink/pull/27096#discussion_r2418708536
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlNodeConvertUtils.java:
##########
@@ -85,11 +85,7 @@ static CatalogView toCatalogView(
context.getSqlValidator().getNamespace(validateQuery);
validateDuplicatedColumnNames(query, viewFields, validatedNamespace);
- // The LATERAL operator was eliminated during sql validation, thus the
unparsed SQL
- // does not contain LATERAL which is problematic,
- // the issue was resolved in CALCITE-4077
- // (always treat the table function as implicitly LATERAL).
- String expandedQuery = context.expandSqlIdentifiers(originalQuery);
+ String expandedQuery = context.toQuotedSqlString(query);
Review Comment:
Based on test checks (their plans)
https://github.com/apache/flink/blob/48aed8418d6ab27b6dc12b101d3f438ff9005d9c/flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/common/ViewsExpandingTest.xml#L117-L139
exec plan contains expanded version.
The only thing which might break: if there is anywhere in downstream
projects the logic heavily relying on `show create view` output since it will
change after this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
