yunfengzhou-hub commented on code in PR #26381: URL: https://github.com/apache/flink/pull/26381#discussion_r2425269780
########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/SinkReuser.java: ########## Review Comment: @xiangyuf If so, this jira seems to contain two parts: 1. removing the method getTargetColumns in DynamicTableSink/Sink/SinkRuntimeProviderContext. This is blocked by the release of Flink 2.2. 2. removing the usage of targetColumns in SinkReuser. This is only blocked by the current PR. Thus it might be better to create a separate jira for the second work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
