davidradl commented on code in PR #27058:
URL: https://github.com/apache/flink/pull/27058#discussion_r2389178204
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java:
##########
@@ -176,14 +176,17 @@ public static SavepointRestoreSettings forPath(
public static void toConfiguration(
final SavepointRestoreSettings savepointRestoreSettings,
final Configuration configuration) {
- configuration.set(
- StateRecoveryOptions.SAVEPOINT_IGNORE_UNCLAIMED_STATE,
- savepointRestoreSettings.allowNonRestoredState());
- configuration.set(
- StateRecoveryOptions.RESTORE_MODE,
savepointRestoreSettings.getRecoveryClaimMode());
- final String savepointPath = savepointRestoreSettings.getRestorePath();
- if (savepointPath != null) {
- configuration.set(StateRecoveryOptions.SAVEPOINT_PATH,
savepointPath);
+ if (!savepointRestoreSettings.equals(SavepointRestoreSettings.none()))
{
Review Comment:
I am curious how this fix works. I see that the only case the fix will
effect is the none case , how does the unit test relate to the none case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
