davidradl commented on code in PR #27055:
URL: https://github.com/apache/flink/pull/27055#discussion_r2387862150
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/RemoveUnreachableCoalesceArgumentsRule.java:
##########
@@ -100,6 +105,10 @@ public RexNode visitCall(RexCall call) {
}
}
+ if (containsFunctionCalls(call)) {
Review Comment:
Please could you raise a Jira for this with the motivation behind this
change and reference the Jira in the title. From the code it looks like this is
more than an optimization it is adding function specific code, it would be good
to call out the value being added here and/or symptoms/ behaviour/ errors that
might be seen prior to this change.
As there is logic added in the change , I suggest adding unit tests for the
code you have added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
