wzx140 opened a new pull request, #27038:
URL: https://github.com/apache/flink/pull/27038

   ## What is the purpose of the change
   
   The finish and reset methods in 
org.apache.flink.table.runtime.arrow.writers.MapWriter should be implemented in 
the same way as in org.apache.flink.table.runtime.arrow.writers.RowWriter.
   
   Otherwise, the following sequence will lead to incorrect behavior:
   
    
   ```
   MapWriter.write
   // Arrow data is right
   MapWriter.finish
   MapWriter.reset
   MapWriter.write
   // Arrow data is wrong, map is null
   MapWriter.finish
   ```
   
   
   
   ## Brief change log
   
   Add finish/reset for keyWriter/valueWriter in ArrowMapWriter.
   
   
   ## Verifying this change
   
   Add UT
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to