snuyanzin commented on code in PR #27132:
URL: https://github.com/apache/flink/pull/27132#discussion_r2444405517
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java:
##########
@@ -1424,7 +1424,7 @@ void createMaterializedTableWithDistribution() throws
Exception {
+ " CONSTRAINT `PK_user_id` PRIMARY KEY (`user_id`)
NOT ENFORCED\n"
+ "), comment='null', distribution=DISTRIBUTED BY
HASH(`user_id`) INTO 7 BUCKETS, partitionKeys=[], "
+ "options={format=debezium-json}, snapshot=null,
definitionQuery='SELECT 1 AS `shop_id`, 2 AS `user_id`', "
- + "freshness=INTERVAL '30' SECOND,
logicalRefreshMode=AUTOMATIC, refreshMode=CONTINUOUS, "
+ + "freshness=INTERVAL '30' SECOND,
logicalRefreshMode=AUTOMATIC, refreshMode=null, "
Review Comment:
then would make sense to have a test with non null value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]