Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3095#discussion_r95754128
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/SortITCase.scala
---
@@ -57,14 +57,8 @@ class SortITCase(
- x.productElement(0).asInstanceOf[Int] )
val expected = sortExpectedly(tupleDataSetStrings)
- val results = t.toDataSet[Row].mapPartition(rows =>
Seq(rows.toSeq)).collect()
-
- val result = results
- .filterNot(_.isEmpty)
- .sortBy(_.head)(Ordering.by(f=> f.toString))
--- End diff --
We should change this to ` .sortBy(_.head)` and provide an implicit
ordering for `Row`.
When we changed `Row` to not extend `Product`, we should have added the
implicit ordering for `Row` instead of sorting by String.
The same applies to the other tests in this class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
