rkhachatryan commented on code in PR #27070:
URL: https://github.com/apache/flink/pull/27070#discussion_r2447416416
##########
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/streaming/util/TestStreamEnvironment.java:
##########
@@ -206,6 +208,13 @@ private static void randomizeConfiguration(MiniCluster
miniCluster, Configuratio
ConfigOptions.key("table.exec.unbounded-over.version").intType().noDefaultValue(),
1,
2);
+ randomize(
+ conf,
+ TABLE_EXEC_SINK_UPSERT_MATERIALIZE_STRATEGY,
+ ExecutionConfigOptions.SinkUpsertMaterializeStrategy.LEGACY,
+ ExecutionConfigOptions.SinkUpsertMaterializeStrategy.VALUE,
+ ExecutionConfigOptions.SinkUpsertMaterializeStrategy.MAP,
+ ExecutionConfigOptions.SinkUpsertMaterializeStrategy.ADAPTIVE);
Review Comment:
There were about 5-10 distinct tests failing after enabling this feature
(either due to compiled plan compatibility, or invalid generated class name,
which I both have fixed). But this doesn't tell much, in most cases it
shouldn't fail.
I pushed 8c33f069fe609c0546efb549b42445becda7f9b4 (a separate PR) to get
some estimates. I don't know any better ways to get this number :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
