davidradl commented on code in PR #27133:
URL: https://github.com/apache/flink/pull/27133#discussion_r2447969769
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/ChangelogNormalizeTestPrograms.java:
##########
@@ -281,7 +281,7 @@ public class ChangelogNormalizeTestPrograms {
.build())
.runSql(
"INSERT INTO sink_t SELECT a, b, c FROM source_t
WHERE b < 10 AND "
- + "CURRENT_WATERMARK(d) IS NULL OR "
- + "CURRENT_WATERMARK(d) >= TIMESTAMP
'1970-01-01 00:00:00'")
+ + "(CURRENT_WATERMARK(d) IS NULL OR "
Review Comment:
Please could you follow the
[process](https://flink.apache.org/how-to-contribute/contribute-code/#code-contribution-process)
and either label this as a hotfix or reference the associated Jira.
The should be some explanation as to the what this change is for in the Jira
or the PR text if this is a hotfix.
I am curious about the lines you have added - I think the SQL is not valid
as it should have an AND or OR before the new condition you add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
