davidradl commented on code in PR #27136:
URL: https://github.com/apache/flink/pull/27136#discussion_r2452216831
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/util/stats/StatsSummaryDto.java:
##########
@@ -149,11 +149,11 @@ public boolean equals(Object o) {
return minimum == that.minimum
&& maximum == that.maximum
&& average == that.average
- && p50 == that.p50
- && p90 == that.p90
- && p95 == that.p95
- && p99 == that.p99
- && p999 == that.p999;
+ && Double.compare(p50, that.p50) == 0
Review Comment:
I am thinking that NaN should never be in the stats, would a better root
cause fix be to police the code, so that NaN is never written. I assume NaN
does not mean anything in this context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
