GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/3104

    [FLINK-5150] [webui] Store metrics in sessionStorage

    This PR modifies the webfrontend to no longer store the metrics setup 
(selected metrics + their values) in localStorage but sessionStorage instead.
    
    Using localStorage means that data is never deleted unless explicitly told. 
It survives moving across pages, but also browser restarts. We currently lack 
an automatic explicit removal, which was problematic since metrics for previous 
jobs (that may even have been executed on a completely different cluster) were 
still being updated. For example, if i ran any job on my local machine it would 
fire 30+ requests regularly for dead metrics.
    
    By moving to sessionStorage this issue is solved since the data is cleared 
when the page is closed. However, you can still navigate to other pages and the 
setup will survive. As a bonus you can now have 2 tabs for the same task with 
different metric setups!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 5150_webui_rl

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3104
    
----
commit bb0415c2e879e3a2b5e977484c529d3d6a94c657
Author: zentol <[email protected]>
Date:   2017-01-12T12:12:24Z

    [FLINK-5150] [webui] Store metrics in sessionStorage

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to