echauchot commented on PR #32: URL: https://github.com/apache/flink-connector-cassandra/pull/32#issuecomment-3452345147
> Good afternoon! It looks like this PR has been abandoned for some time, but I’d be happy to pick it up and get it over the line. I’d appreciate any guidance on the best way to proceed. @echauchot, I noticed you’ve been active in this repo - maybe you could advise? I would plan to create a fork, apply the original author’s changes (keeping them as a co-author), resolve conflicts with main, and open a new PR. > > Thanks a lot in advance! @andrii-kysylevskyi Yes, you need a fork of the cassandra connector repo, clone it locally, then checkout the PR branch locally for testing (ex for PR 35 on first iteration of review with apache being the remote pointing to the apache repo `git fetch apache pull/35/head:pr_35_1 ` ). Then review it. Once it is approved, a Flink committer can merge. But unfortunately I have no time for reviewing as I'm starting a new job. As a quick review comment, I'd recommend to add ITests on Scylladb using testConainers Scylladb backend to be able to claim support. I'd hope no change to the prod code is needed and that only a new ITest is enough. Agree on the general idea of using the connector for both DB. Also careful on the doc integration: the connectors docs are integrated from a version branch of the connector to the main Flink doc see [doc integraion](https://cwiki.apache.org/confluence/display/FLINK/Creating+a+flink-connector+release#Creatingaflinkconnectorrelease-UpdateandproperlyintegratetheconnectordocumentationintheFlinkdocumentation(onlyforregularconnectorrelease,notflink-connector-parent)). I think we could update the doc once the test is passing and with new changes from @Poorvankbhatia and release a v3.3 of the connector and reference v3.3 as described in the doc integration procedure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
