[ 
https://issues.apache.org/jira/browse/FLINK-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821232#comment-15821232
 ] 

ASF GitHub Bot commented on FLINK-5118:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3106#discussion_r95812448
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java
 ---
    @@ -99,7 +99,7 @@ public SerializationResult addRecord(T record) throws 
IOException {
                this.lengthBuffer.putInt(0, len);
                
                if (numBytesOut != null) {
    -                   numBytesOut.inc(len);
    +                   numBytesOut.inc(len + 4);
    --- End diff --
    
    I think this warrants both a comment and a test.


> Inconsistent records sent/received metrics
> ------------------------------------------
>
>                 Key: FLINK-5118
>                 URL: https://issues.apache.org/jira/browse/FLINK-5118
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics, Webfrontend
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: Ufuk Celebi
>            Assignee: Chesnay Schepler
>             Fix For: 1.2.0, 1.3.0
>
>
> In 1.2-SNAPSHOT running a large scale job you see that the counts for 
> send/received records are inconsistent, e.g. in a simple word count job we 
> see more received records/bytes than we see sent. This is a regression from 
> 1.1 where everything works as expected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to