bgeng777 commented on code in PR #27176:
URL: https://github.com/apache/flink/pull/27176#discussion_r2490559878
##########
flink-python/src/test/java/org/apache/flink/client/python/PythonDriverTest.java:
##########
@@ -62,7 +62,8 @@ void testConstructCommandsWithEntryPointScript() {
args.add("--input");
args.add("in.txt");
- PythonDriverOptions pythonDriverOptions = new
PythonDriverOptions(null, "xxx.py", args);
+ PythonDriverOptions pythonDriverOptions =
+ new PythonDriverOptions(null, null, "xxx.py", args);
Review Comment:
nit: the test itself is fine, but IIUC, the `pythonDependencyConfig` field
could not be null or codes like
`config.addAll(pythonDriverOptions.getPythonDependencyConfig());` will throw
NPE. In the production codes, `parsePythonDependencyConfiguration` gurantees it
with `new Configuration()`, but the test may be misleading as it makes the
`pythonDependencyConfig` null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
