agresch commented on code in PR #27034:
URL: https://github.com/apache/flink/pull/27034#discussion_r2491274561
##########
flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java:
##########
@@ -67,13 +70,15 @@
/** Common utilities to manage SSL transport settings. */
public class SSLUtils {
+ private static final Logger LOG = LoggerFactory.getLogger(SSLUtils.class);
+
/**
* Creates a factory for SSL Server Sockets from the given configuration.
SSL Server Sockets are
* always part of internal communication.
*/
public static ServerSocketFactory
createSSLServerSocketFactory(Configuration config)
throws Exception {
- SSLContext sslContext = createInternalSSLContext(config, false);
+ SSLContext sslContext = createInternalSSLContext(config, false, false);
Review Comment:
I'm not really familiar with Flink code, but can you explain why the server
socket wouldn't need to watch for cert reload? I think that would be worth a
comment as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
