ferenc-csaky commented on code in PR #6:
URL:
https://github.com/apache/flink-connector-http/pull/6#discussion_r2518803506
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/table/lookup/HttpLookupConnectorOptions.java:
##########
@@ -74,6 +75,18 @@ public class HttpLookupConnectorOptions {
public static final ConfigOption<String> LOOKUP_QUERY_CREATOR_IDENTIFIER =
ConfigOptions.key(SOURCE_LOOKUP_QUERY_CREATOR_IDENTIFIER).stringType().noDefaultValue();
+ public static final ConfigOption<String> LOOKUP_HTTP_VERSION =
+ ConfigOptions.key(SOURCE_LOOKUP_QUERY_HTTP_VERSION)
+ .stringType()
+ .noDefaultValue()
+ .withDescription(
Review Comment:
Ah, now that i looked into this, it won't be useful here in a connector
repo, cause this builder helps generating an HTML table, but that doc
generation logic is now limited to the core Flink repo. :/ So feel free to
revert it to raw text, sorry for the extra loop. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
