rionmonster commented on code in PR #27252:
URL: https://github.com/apache/flink/pull/27252#discussion_r2542085287
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/deltajoin/DeltaJoinCache.java:
##########
@@ -87,7 +87,7 @@ public void registerMetrics(MetricGroup metricGroup) {
:
Long.valueOf(leftHitCount.get()).doubleValue()
/ leftRequestCount.get());
metricGroup.<Long, Gauge<Long>>gauge(
- LEFT_CACHE_METRIC_PREFIX + METRIC_REQUEST_COUNT,
rightRequestCount::get);
+ LEFT_CACHE_METRIC_PREFIX + METRIC_REQUEST_COUNT,
leftRequestCount::get);
Review Comment:
I just came across this from a separate similar PR and left similar
feedback. The fix itself seems pretty straightforward for an obvious bug --
just wasn't sure if there was test coverage related to these change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
