[
https://issues.apache.org/jira/browse/FLINK-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823624#comment-15823624
]
ASF GitHub Bot commented on FLINK-4988:
---------------------------------------
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3112
Hi @rmetzger, I've addressed your review comments. I still have some
problems however, on the following:
1. I can't really reproduce the problem with the conflicts in
`META-INF/services` dependencies, hence couldn't really try out whether that
actually works correctly or if would actually use the
`ServiceResourceTransformer` instead of `AppenderTransformer`. From the Maven
documentation and what I understand from what the original ES2 documentation
was trying to address, I think we can use the `ServiceResourceTransformer`.
What do you think?
2. Regarding Log4j 2 dependency: That is required for the ES 5 Java client
to log correctly, since the ES 5 Java API now uses Log4j 2 and does not detect
logging implementations, must have a Log4j 2 API in the classpath. So the way I
think the ES 5 connector is working is that the connector logs and Flink itself
are logging using Log4j 1, while the internally used ES Java client is using
Log4j 2 included exclusively in ES 5's POM.
I am still figuring out how to get the internal ES Java client in the ES 5
connector to log to TaskManager logs when using cluster execution, though (the
connector log and Flink log is correctly logged, only the ES Java client log is
missing).
I've included this `log4j2.properties` in a test project to be packaged for
execution:
```
appender.file.type=File
appender.file.filename=${log.file}
appender.file.name=file
appender.file.layout.type=PatternLayout
appender.file.layout.pattern=%-4r [%t] %-5p %c %x - %m%n
rootLogger.level=info
rootLogger.appenderRef.file.ref=file
```
Somehow, it isn't picking the `log.file` property, which is set by the
`flink-daemon.sh` script as a system property. Changing `log.file` to some
another specific file path works.
> Elasticsearch 5.x support
> -------------------------
>
> Key: FLINK-4988
> URL: https://issues.apache.org/jira/browse/FLINK-4988
> Project: Flink
> Issue Type: New Feature
> Reporter: Mike Dias
>
> Elasticsearch 5.x was released:
> https://www.elastic.co/blog/elasticsearch-5-0-0-released
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
