raminqaf commented on code in PR #27292: URL: https://github.com/apache/flink/pull/27292#discussion_r2577582817
########## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlAlterMaterializedTableSchema.java: ########## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.sql.parser.ddl; + +import org.apache.flink.sql.parser.ExtendedSqlNode; +import org.apache.flink.sql.parser.SqlConstraintValidator; +import org.apache.flink.sql.parser.SqlUnparseUtils; +import org.apache.flink.sql.parser.ddl.constraint.SqlTableConstraint; +import org.apache.flink.sql.parser.ddl.position.SqlTableColumnPosition; +import org.apache.flink.sql.parser.error.SqlValidateException; + +import org.apache.calcite.sql.SqlIdentifier; +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlNodeList; +import org.apache.calcite.sql.SqlWriter; +import org.apache.calcite.sql.parser.SqlParserPos; +import org.apache.calcite.util.ImmutableNullableList; + +import javax.annotation.Nonnull; +import javax.annotation.Nullable; + +import java.util.List; +import java.util.Optional; +import java.util.stream.Collectors; + +/** + * Abstract class to describe statements which are used to alter schema for materialized tables. See + * examples in javadoc for {@link SqlAlterMaterializedTableAddSchema}. + */ +public abstract class SqlAlterMaterializedTableSchema extends SqlAlterMaterializedTable + implements ExtendedSqlNode { + + protected final SqlNodeList columnList; + protected final List<SqlTableConstraint> constraints; + protected final @Nullable SqlWatermark watermark; + + public SqlAlterMaterializedTableSchema( + SqlParserPos pos, + SqlIdentifier materializedTableName, + SqlNodeList columnList, + List<SqlTableConstraint> constraints, + @Nullable SqlWatermark sqlWatermark) { + super(pos, materializedTableName); + this.columnList = columnList; + this.constraints = constraints; + this.watermark = sqlWatermark; + } + + @Nonnull + @Override + public List<SqlNode> getOperandList() { + return ImmutableNullableList.of( + name, columnList, new SqlNodeList(constraints, SqlParserPos.ZERO), watermark); + } + + @Override + public void validate() throws SqlValidateException { + SqlConstraintValidator.validateAndChangeColumnNullability(constraints, getColumns()); + } + + public SqlNodeList getColumnPositions() { + return columnList; + } + + public Optional<SqlWatermark> getWatermark() { + return Optional.ofNullable(watermark); + } + + public List<SqlTableConstraint> getConstraints() { + return constraints; + } + + private SqlNodeList getColumns() { + return new SqlNodeList( + columnList.getList().stream() + .map(columnPos -> ((SqlTableColumnPosition) columnPos).getColumn()) + .collect(Collectors.toList()), + SqlParserPos.ZERO); + } + + protected abstract String getAlterOperation(); + + @Override + public void unparseAlterOperation(SqlWriter writer, int leftPrec, int rightPrec) { + super.unparseAlterOperation(writer, leftPrec, rightPrec); + writer.keyword(getAlterOperation()); + SqlUnparseUtils.unparseTableSchema( + columnList, constraints, watermark, writer, leftPrec, rightPrec); + } + + /** + * Example: DDL like the below for add column/constraint/watermark. Review Comment: Super nit: ```suggestion * Example: DDL like the below for adding column/constraint/watermark. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
