1996fanrui commented on PR #182: URL: https://github.com/apache/flink-connector-jdbc/pull/182#issuecomment-3641089955
Thanks @och5351 for the contribution, and @RocMarshal for the review! I have 3 comments for this PR, please take a look when you are available, thanks - It looks more like a feature or improvement instead of hotfix, is not it? If yes, it is better to have a separate jira. - I do not think `[Connector/JDBC]` is required in commit message as this is a separate repo for jdbc connector. Of course, including `[Connector/JDBC]` is also fine. - CI is failed, please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
