yuxiqian commented on code in PR #3918:
URL: https://github.com/apache/flink-cdc/pull/3918#discussion_r2609905106
##########
docs/content.zh/docs/core-concept/data-pipeline.md:
##########
@@ -118,3 +122,4 @@ under the License.
| local-time-zone | 作业级别的本地时区。
| optional |
| execution.runtime-mode | pipeline 的运行模式，包含 STREAMING 和 BATCH，默认值是 STREAMING。
| optional |
| operator.uid.prefix | Pipeline 中算子 UID 的前缀。如果不设置，Flink 会为每个算子生成唯一的 UID。
建议设置这个参数以提供稳定和可识别的算子 ID，这有助于有状态升级、问题排查和在 Flink UI 上的诊断。 | optional |
+| flink-conf |
用于配置[Flink相关参数](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/)。
<br/>Flink参数优先级：config.yaml < job command-line < pipeline.yaml | optional
|
Review Comment:
```suggestion
| flink-conf | 用于配置[Flink
参数](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/)。
<br/>Flink 参数生效优先级（由高到低）为 Command Line、Pipeline YAML 块、Flink `config.yaml`。 |
optional |
```
##########
docs/content/docs/core-concept/data-pipeline.md:
##########
@@ -124,6 +126,8 @@ Note that whilst the parameters are each individually
optional, at least one of
| `schema.operator.uid` | The unique ID for schema operator. This ID
will be used for inter-operator communications and must be unique across
operators. **Deprecated**: use `operator.uid.prefix` instead.
| optional |
| `schema-operator.rpc-timeout` | The timeout time for SchemaOperator to wait
downstream SchemaChangeEvent applying finished, the default value is 3 minutes.
| optional |
| `operator.uid.prefix` | The prefix to use for all pipeline operator
UIDs. If not set, all pipeline operator UIDs will be generated by Flink. It is
recommended to set this parameter to ensure stable and recognizable operator
UIDs, which can help with stateful upgrades, troubleshooting, and Flink UI
diagnostics.
| optional |
-
+| flink-conf | Used to configure [Flink related
parameters](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/).
<br/>Flink parameter priority: config.yaml < job command-line < pipeline.yaml
| optional |
NOTE: Whilst the above parameters are each individually optional, at least one
of them must be specified. The `pipeline` section is mandatory and cannot be
empty.
+
Review Comment:
Revert accidental changes
##########
docs/content.zh/docs/deployment/yarn.md:
##########
@@ -126,7 +126,14 @@ sink:
pipeline:
name: Sync MySQL Database to Doris
parallelism: 2
-
+ flink-conf:
+ rest.bind-port: {{REST_PORT}}
+ rest.address: {{NODE_IP}}
+ execution.target: yarn-session
+ yarn.application.id: {{YARN_APPLICATION_ID}}
+ execution.checkpointing.interval: 2min
+ #如果需要从savepoint恢复，则配置以下参数
+ #execution.savepoint.path: hdfs:///flink/savepoint-1537
Review Comment:
```suggestion
# 如需从 savepoint 恢复，可配置以下参数：
# execution.savepoint.path: hdfs:///flink/savepoint-1537
```
##########
docs/content/docs/deployment/yarn.md:
##########
@@ -128,7 +128,14 @@ sink:
pipeline:
name: Sync MySQL Database to Doris
parallelism: 2
-
+ flink-conf:
+ rest.bind-port: {{REST_PORT}}
+ rest.address: {{NODE_IP}}
+ execution.target: yarn-session
+ yarn.application.id: {{YARN_APPLICATION_ID}}
+ execution.checkpointing.interval: 2min
+ #If you need to restore from a savepoint, configure the following
parameters:
Review Comment:
```suggestion
# If you need to restore from a savepoint, uncomment the next line:
```
##########
flink-cdc-cli/src/main/java/org/apache/flink/cdc/cli/CliFrontend.java:
##########
Review Comment:
Please add an Pipeline E2e case to verify the priority of Flink config, YAML
`flink-conf` block, and CDC CLI arguments.
##########
docs/content/docs/core-concept/data-pipeline.md:
##########
@@ -124,6 +126,8 @@ Note that whilst the parameters are each individually
optional, at least one of
| `schema.operator.uid` | The unique ID for schema operator. This ID
will be used for inter-operator communications and must be unique across
operators. **Deprecated**: use `operator.uid.prefix` instead.
| optional |
| `schema-operator.rpc-timeout` | The timeout time for SchemaOperator to wait
downstream SchemaChangeEvent applying finished, the default value is 3 minutes.
| optional |
| `operator.uid.prefix` | The prefix to use for all pipeline operator
UIDs. If not set, all pipeline operator UIDs will be generated by Flink. It is
recommended to set this parameter to ensure stable and recognizable operator
UIDs, which can help with stateful upgrades, troubleshooting, and Flink UI
diagnostics.
| optional |
-
+| flink-conf | Used to configure [Flink related
parameters](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/).
<br/>Flink parameter priority: config.yaml < job command-line < pipeline.yaml
| optional |
Review Comment:
```suggestion
| flink-conf | Used to configure [Flink related
parameters](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/).
<br/> Flink configurations will take effect in the following order (high to
low): CDC CLI arguments, YAML Pipeline config blocks, and Flink `config.yaml`.
| optional |
```
##########
docs/content/docs/connectors/pipeline-connectors/starrocks.md:
##########
@@ -59,6 +59,8 @@ sink:
pipeline:
name: MySQL to StarRocks Pipeline
parallelism: 2
+ flink-conf:
Review Comment:
No need to modify documents of every connector, it's optional anyway. It has
been described in the pipeline concept page.
##########
docs/content.zh/docs/core-concept/data-pipeline.md:
##########
@@ -118,3 +122,4 @@ under the License.
| local-time-zone | 作业级别的本地时区。
| optional |
| execution.runtime-mode | pipeline 的运行模式，包含 STREAMING 和 BATCH，默认值是 STREAMING。
| optional |
| operator.uid.prefix | Pipeline 中算子 UID 的前缀。如果不设置，Flink 会为每个算子生成唯一的 UID。
建议设置这个参数以提供稳定和可识别的算子 ID，这有助于有状态升级、问题排查和在 Flink UI 上的诊断。 | optional |
+| flink-conf |
用于配置[Flink相关参数](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/)。
<br/>Flink参数优先级：config.yaml < job command-line < pipeline.yaml | optional
|
Review Comment:
I don't think the YAML `flink-conf` block should have higher priority than
CLI arguments. IIRC Flink SQL client and CLI arguments could override static
config files, too.
A reasonable priority order might be CDC CLI arguments > YAML `flink-conf`
block > Flink cluster config file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
