yuxiqian opened a new pull request, #4191:
URL: https://github.com/apache/flink-cdc/pull/4191

   This closes FLINK-38806.
   
   A post-transform converter will not work if neither projection nor filter 
rule is defined, as such transform definitions are ignored in 
TransformTranslator.
   
   ```yaml
   transform:
     - source-table: foo.bar
       converter-after-transform: SOFT_DELETE
   ```
   
   Questionable code snippet:
   
   ```diff
   // TransformTranslator.java
   
    for (TransformDef transform : transforms) {
   -    if (transform.isValidProjection() || transform.isValidFilter()) {
            postTransformFunctionBuilder.addTransform(
                    transform.getSourceTable(),
                    transform.getProjection(),
                    transform.getFilter(),
                    transform.getPrimaryKeys(),
                    transform.getPartitionKeys(),
                    transform.getTableOptions(),
                    transform.getPostTransformConverter(),
                    supportedMetadataColumns);
        }
    }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to