davidradl commented on code in PR #27337:
URL: https://github.com/apache/flink/pull/27337#discussion_r2618602372
##########
flink-metrics/flink-metrics-otel/src/main/java/org/apache/flink/traces/otel/OpenTelemetryTraceReporter.java:
##########
@@ -70,10 +70,14 @@ public void open(MetricConfig metricConfig) {
@Override
public void close() {
- spanProcessor.forceFlush();
- spanProcessor.close();
- spanExporter.flush();
- spanExporter.close();
+ if (spanProcessor != null) {
Review Comment:
I know this is a back port, I am wondering if we get an exception
processing the spanProcessor shouldn't we still try to clean up spanExporter if
we have one. i.e. put the spanExporter code in a finally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
