och5351 commented on code in PR #183:
URL:
https://github.com/apache/flink-connector-jdbc/pull/183#discussion_r2621309282
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/database/JdbcFactory.java:
##########
@@ -64,6 +64,13 @@ default JdbcDialect createDialect(String compatibleMode) {
"Not supported option 'compatible-mode' with value: " +
compatibleMode);
}
+ JdbcCatalog createCatalog(
Review Comment:
Hi, @RocMarshal
Oh, I completely misunderstood.
You were referring to `createCatalog` in `JdbcFactory`, but I was actually
thinking about `loadCatalog`. I was focusing on the `optionalOptions` in
`JdbcCatalogFactory` and thought a new `createCatalog` method was needed, but
it turns out it’s not necessary.
Also, I found the `createCatalog` method in `FactoryUtil`.
Now I understand your review and really appreciate your patience.
If you have more time, could you please take a look at the changes again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
