Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3106
+1 to this approach.
Some suggestions for small performance improvements, not specific to this
case, but also applicable to other cases:
- It may make sense to type the counters at that level to the
"SimpleCounter", if we anyways provide them. The TaskIOMetricGroup could type
its counters to "SimpleCounter" as well. Since that class it not final, and
future mocks/checks can be implemented on that class as well
- We can make sure that the field `counter` is always initialized by
initially assigning a standalone SimpleCounter. That way we could drop the null
checks in the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
