dylanhz commented on code in PR #27354:
URL: https://github.com/apache/flink/pull/27354#discussion_r2638945210
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala:
##########
@@ -301,7 +301,11 @@ object CodeGenUtils {
// ordered by type root definition
case CHAR | VARCHAR => s"$BINARY_STRING.EMPTY_UTF8"
case BOOLEAN => "false"
- case TINYINT | SMALLINT | INTEGER | DATE | TIME_WITHOUT_TIME_ZONE |
INTERVAL_YEAR_MONTH => "-1"
+ // Janino does not support implicit narrowing for ternary expressions,
Review Comment:
I think maybe we can remove the comment now. Since the code now provides
explicit types, we're no longer relying on narrowing, and there's no need to
document the workaround. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
