Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3120#discussion_r96232469
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/query/QueryableStateClient.java
---
@@ -341,7 +341,34 @@ public void shutDown() {
return previous;
}
} else {
- return cachedFuture;
+ // do not retain futures which failed as they
will remain in
+ // the cache even if the error cause is not
present any more
+ // and a new lookup may succeed
+ boolean isFailedFuture = false;
+ if (cachedFuture.isCompleted()) {
+ // find out if the future failed
+ try {
+
cachedFuture.value().get().get();
--- End diff --
I think you can do `cachedFuture.value().get().isFailure()` instead of
catching the Exception here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
