mxm commented on code in PR #1047:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1047#discussion_r2660673996
##########
tools/maven/checkstyle.xml:
##########
@@ -230,8 +230,8 @@ This file is based on the checkstyle file of Apache Beam.
<message key="import.illegal" value="{0}; Use
flink-shaded-netty instead."/>
</module>
<module name="IllegalImport">
- <property name="illegalPkgs" value="com.google.common"/>
- <message key="import.illegal" value="{0}; Use
flink-shaded-guava instead."/>
+ <property name="illegalPkgs"
value="org.apache.flink.shaded.guava31"/>
Review Comment:
Should this regex be a bit more general to guard against new shaded guava
releases?
```suggestion
<property name="illegalPkgs"
value="org.apache.flink.shaded.guava.*"/>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
