mattcuento commented on code in PR #27386:
URL: https://github.com/apache/flink/pull/27386#discussion_r2665351030
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/tvf/operator/AlignedWindowTableFunctionOperator.java:
##########
@@ -46,8 +46,9 @@ public class AlignedWindowTableFunctionOperator extends
WindowTableFunctionOpera
public AlignedWindowTableFunctionOperator(
GroupWindowAssigner<TimeWindow> windowAssigner,
int rowtimeIndex,
+ int timestampPrecision,
ZoneId shiftTimeZone) {
- super(windowAssigner, rowtimeIndex, shiftTimeZone);
+ super(windowAssigner, rowtimeIndex, timestampPrecision, shiftTimeZone);
Review Comment:
I might be a bit confused on what you mean. Is the desire for a new
constructor in `WindowTableFunctionOperatorBase ` with a signature that passes
`timestampPrecision`?
If so, the only two usages are for these two implementations,
`AlignedWindowTableFunctionOperator` and
`UnalignedWindowTableFunctionOperator`. Intended behavior here would be to
always pass `timestampPrecision` through a concrete operator instance as
opposed to defaulting to any given value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
