rmetzger commented on code in PR #27370:
URL: https://github.com/apache/flink/pull/27370#discussion_r2668838582
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/canal/CanalJsonDeserializationSchema.java:
##########
@@ -288,13 +293,22 @@ public void deserialize(@Nullable byte[] message,
Collector<RowData> out) throws
"Unknown \"type\" value \"%s\". The Canal
JSON message is '%s'",
Review Comment:
nit to the nit: It is not the same content. `%s` vs `{}`. Sharing this
string would potentially make the whole code unnecessarily complex, and this
part of the code is probably performance critical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
