lvyanquan commented on code in PR #4215:
URL: https://github.com/apache/flink-cdc/pull/4215#discussion_r2675137505
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-maxcompute/src/main/java/org/apache/flink/cdc/connectors/maxcompute/utils/SchemaEvolutionUtils.java:
##########
@@ -124,7 +124,12 @@ public static void addColumns(
.append(" ")
.append(string(addColumn.getAddColumn().getType()))
.append(" comment '")
-
.append(addColumn.getAddColumn().getType().asSummaryString())
+ // Use column comment if available, otherwise use type
description as
+ // fallback
+ .append(
+ addColumn.getAddColumn().getComment() != null
+ ? addColumn.getAddColumn().getComment()
+ :
addColumn.getAddColumn().getType().asSummaryString())
Review Comment:
I believe the original comment was caused by a coding error, and we do not
need to retain the previous configuration scheme.
We can directly use the new comment (or null) instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
