ferenc-csaky commented on code in PR #12:
URL:
https://github.com/apache/flink-connector-http/pull/12#discussion_r2677051937
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/table/lookup/JavaNetHttpPollingClient.java:
##########
@@ -327,21 +328,22 @@ private Collection<RowData> deserialize(String
responseBody) throws IOException
}
private List<RowData> deserializeSingleValue(byte[] rawBytes) throws
IOException {
- return Optional.ofNullable(responseBodyDecoder.deserialize(rawBytes))
- .map(Collections::singletonList)
- .orElse(Collections.emptyList());
+ List<RowData> result = new ArrayList<>();
+ responseBodyDecoder.deserialize(rawBytes, new ListCollector(result));
+ return result;
Review Comment:
One thing I missed before, let's wrap it to
`Collections.unmodifiableList(result)`, cause the prev. code returned an
immutable list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
