linjianchang commented on code in PR #3995:
URL: https://github.com/apache/flink-cdc/pull/3995#discussion_r2675514566
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-debezium/src/main/java/org/apache/flink/cdc/debezium/event/DebeziumSchemaDataTypeInference.java:
##########
@@ -185,6 +185,9 @@ protected DataType inferBytes(Object value, Schema schema) {
if (precision > DecimalType.MAX_PRECISION) {
return DataTypes.STRING();
}
+ if (scale < 0 || scale > 36) {
+ return DataTypes.STRING();
Review Comment:
> Please explain why this change is necessary.
<img width="1133" height="770" alt="企业微信截图_17679497824493"
src="https://github.com/user-attachments/assets/e5a85333-7b57-4aa0-82d7-42e22439881b";
/>
"Does Oracle's 'nember' type have a Scala value?"
It is in the range of 0-36 in decimal, so it is not in the decimal range
Convert to string
All sources in the pipeline have been tested with fulltype's ut and are
normal. This change has not affected other connectors.
<img width="758" height="569" alt="企业微信截图_17679536267111"
src="https://github.com/user-attachments/assets/269f3587-2297-42e8-b3a2-2dd4a8582c30";
/>
<img width="730" height="396" alt="企业微信截图_17682126247568"
src="https://github.com/user-attachments/assets/7d647e55-a620-474d-8e8d-a0ce2c2015c0";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
