mateczagany commented on code in PR #27407:
URL: https://github.com/apache/flink/pull/27407#discussion_r2694777002
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractRestHandler.java:
##########
@@ -85,14 +85,15 @@ protected CompletableFuture<Void> respondToRequest(
response = FutureUtils.completedExceptionally(e);
}
- return response.thenAccept(
+ return response.thenAcceptAsync(
resp ->
HandlerUtils.sendResponse(
ctx,
httpRequest,
resp,
messageHeaders.getResponseStatusCode(),
- responseHeaders));
+ responseHeaders),
+ ctx.executor());
Review Comment:
Oh, nevermind, this is the same issue as before, I was on wrong branch
locally. Unfortunately keeping the Netty version as-is did not help get rid of
this.
If you try to run this test suite locally, you will see these errors:
`Received fatal alert: certificate_unknown`. This is because starting from
Netty 4.2, SSL hostname verification is on by default. Setting
`security.ssl.verify-hostname` has NO effect, because this is not used
anywhere. So I suggest to change its default value to `false`, and use it to
set SSL hostname verification, as that would allow us to have the same behavior
as before.
The reason you don't see any errors in the CI is that this error causes one
of the tests to hang indefinitely, so no output will be shown of the errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
