davidradl commented on code in PR #27429:
URL: https://github.com/apache/flink/pull/27429#discussion_r2697607123
##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/tasks/SystemProcessingTimeService.java:
##########
@@ -141,7 +141,7 @@ public ScheduledFuture<?> scheduleWithFixedDelay(
private ScheduledFuture<?> scheduleRepeatedly(
ProcessingTimeCallback callback, long initialDelay, long period,
boolean fixedDelay) {
final long nextTimestamp = getCurrentProcessingTime() + initialDelay;
- final Runnable task = wrapOnTimerCallback(callback, nextTimestamp,
period);
+ final Runnable task = wrapOnTimerCallback(callback, nextTimestamp,
period, fixedDelay);
Review Comment:
I am checking the logic on the first time - I would expect the initial delay
to take effect, then subsequent time the fixed delay. As the code is written
the first time we get the initial plus the fixed delay, can you confirm this is
what you want?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
