davidradl commented on code in PR #27285: URL: https://github.com/apache/flink/pull/27285#discussion_r2728167504
########## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/timeline/RescaleTimeline.java: ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.scheduler.adaptive.timeline; + +import org.apache.flink.runtime.scheduler.adaptive.allocator.JobInformation; + +import javax.annotation.Nullable; + +/** The rescale line information updating interface. */ +public interface RescaleTimeline { + + @Nullable + JobInformation getJobInformation(); + + /** + * Judge whether the current rescale in timeline is terminated or empty. + * + * @return <code>ture</code> if contain <code>false</code> else. + */ + boolean inIdling(); + + boolean inRescalingProgress(); + + /** + * Create a new rescale and assign it as current rescale. Note, the {@link #inIdling()} must be + * idling when creating a new current rescale. + * + * @param newRescaleEpoch It represents whether the rescale resource requirements is in the new + * epoch. + * @return <code>ture</code> if create successfully <code>false</code> else. Review Comment: I was expecting the rescale uuid to be returned (or is this something not to be exposed?) and an exception if the rescale could not be created. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
