Savonitar opened a new pull request, #215:
URL: https://github.com/apache/flink-connector-kafka/pull/215
Migrates tests from JUnit 4 to JUnit 5 [FLINK-25538]. Split into 3 commits
for easier review:
- **Commit 1**: The actual migration
- **Commits 2-3**: Cleanup and style fixes
## Commits
**1. Migrate tests from JUnit 4 to JUnit 5**
Main migration JUnit 4 -> JUnit 5. Compiles and tests pass.
**2. Replace `@ExtendWith(TestLoggerExtension)` with global SPI
registration**
Uses SPI registration instead of `@ExtendWith` on every class (feedback from
#106)
**3. Remove optional public modifiers following JUnit 5 best practices**
JUnit 5 doesn't require test classes/methods to be `public`. Removed these
modifiers from migrated files to match modern conventions (also what
Sonar/other linters recommend). Files not migrated in this PR still keep their
`public` modifiers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
