leonardBang commented on code in PR #208:
URL:
https://github.com/apache/flink-connector-kafka/pull/208#discussion_r2757297159
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/enumerator/subscriber/KafkaSubscriber.java:
##########
@@ -47,6 +47,17 @@
@PublicEvolving
public interface KafkaSubscriber extends Serializable {
+ /**
+ * Opens the subscriber. This lifecycle method will be called before {@link
+ * #getSubscribedTopicPartitions(AdminClient)} calls are made.
+ *
+ * <p>Implementations may override this method to initialize any
additional resources (beyond
+ * the Kafka {@link AdminClient}) required for discovering topic
partitions.
+ *
+ * @param initializationContext initialization context for the subscriber.
+ */
+ default void open(InitializationContext initializationContext) {}
Review Comment:
Shouldn't we introduce a FLIP for public API change @Efrat19 @tzulitai
@rmetzger ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
