nateab commented on code in PR #26783:
URL: https://github.com/apache/flink/pull/26783#discussion_r2757669332
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkStreamRuleSets.scala:
##########
@@ -143,11 +143,11 @@ object FlinkStreamRuleSets {
// push filter into the children of a join
FlinkFilterJoinRule.JOIN_CONDITION_PUSH,
// push filter through an aggregation
- CoreRules.FILTER_AGGREGATE_TRANSPOSE,
+ FlinkFilterAggregateTransposeRule.INSTANCE,
// push a filter past a project
FlinkFilterProjectTransposeRule.INSTANCE,
// push a filter past a setop
- CoreRules.FILTER_SET_OP_TRANSPOSE,
+ FlinkFilterSetOpTransposeRule.INSTANCE,
Review Comment:
This PR only updates FlinkStreamRuleSets.scala. Shouldn't we also update
the file `FlinkBatchRuleSets.scala `which still uses Calcite's CoreRules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
