ferenc-csaky commented on code in PR #27453:
URL: https://github.com/apache/flink/pull/27453#discussion_r2759047032


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/RexNodeJsonSerdeTest.java:
##########
@@ -977,6 +1003,24 @@ public void eval(CompletableFuture<String> res, Integer 
i) {
         }
     }
 
+    /** Serializable process table function. */
+    public static class SerializableProcessTableFunction extends 
ProcessTableFunction<String> {

Review Comment:
   @davidradl Ok, so serializable here refers to serializable into the copmiled 
plan, not Java serializable. And a function can be serialized to the compiled 
plan if it's not stateful. So adding an instance level field makes it 
non-serializable. Added a test-case for that too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to