Samrat002 commented on PR #27187: URL: https://github.com/apache/flink/pull/27187#issuecomment-3909536079
> https://github.com/apache/flink/pull/27187#pullrequestreview-3809223555 Hi @Izeren, thanks for raising this. It's a fair point, and I appreciate the thoughtfulness. To clarify the history, the initial patch was indeed PoC-level, focused on proving the idea works end-to-end. However, through multiple rounds of review, both internally and from your feedback, the code has evolved significantly since then. My earlier comment about "PoC priorities" was referring to specific pieces that existed at that point in time, all of which have since been addressed. The current state of the PR is production-ready. I've gone through each component and verified it meets production standards, validating error handling, resource management, edge cases, and test coverage. That said, I completely agree with your general principle. PoC-level code belongs in branches for validation and wider testing, while anything merged to master should meet production quality. That's exactly the bar I've aimed for with the latest revisions. This is no longer PoC-level code. If there are any specific areas where you feel the code still falls short of production quality, I'm happy to address them. Otherwise, I believe the PR is ready to move forward. Thank you for the thorough review. It's genuinely made the implementation better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
