ferenc-csaky commented on code in PR #21:
URL:
https://github.com/apache/flink-connector-http/pull/21#discussion_r2816161965
##########
pom.xml:
##########
@@ -64,44 +64,51 @@ under the License.
TODO is this still valid in Flink connector.
-->
- <flink.version>1.20.0</flink.version>
Review Comment:
This may be opinionated, but I'd define some groups for the props and
separate them by empty lines, or even add comment headers for them. Maybe
something like:
```xml
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<target.java.version>11</target.java.version>
<scala.binary.version>2.12</scala.binary.version>
<maven.compiler.source>${target.java.version}</maven.compiler.source>
<maven.compiler.target>${target.java.version}</maven.compiler.target>
<!-- Flink versions-->
...
<!-- 3rd party versions-->
...
<!-- Plugin versions-->
...
<!-- Config args-->
<flink.surefire.baseArgLine>-XX:+UseG1GC -Xms256m
-XX:+IgnoreUnrecognizedVMOptions
${flink.connector.module.config}
</flink.surefire.baseArgLine>
<!-- can be removed with maven-spotless-plugin:2.38+ -->
<spotless.skip>false</spotless.skip>
</properties>
```
Feel free to shape this in any way you think better, I just tried to come up
with something that would be useful to me and I tend to follow in way it makes
sense in the given project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
