weiqingy commented on code in PR #531:
URL: https://github.com/apache/flink-agents/pull/531#discussion_r2825696347
##########
integrations/mcp/src/main/java/org/apache/flink/agents/integrations/mcp/MCPServer.java:
##########
@@ -77,10 +81,21 @@
*/
public class MCPServer extends Resource {
+ private static final Random RANDOM = new Random();
+
private static final String FIELD_ENDPOINT = "endpoint";
private static final String FIELD_HEADERS = "headers";
private static final String FIELD_TIMEOUT_SECONDS = "timeoutSeconds";
+ private static final String FIELD_TIMEOUT = "timeout";
Review Comment:
nit: There seems to be an inconsistency between FIELD_TIMEOUT ("timeout")
and the existing FIELD_TIMEOUT_SECONDS ("timeoutSeconds"). The @JsonCreator
constructor uses FIELD_TIMEOUT_SECONDS, but the descriptor-based constructor
reads FIELD_TIMEOUT. This means the field name used depends on how the
MCPServer is constructed (JSON deserialization vs descriptor), which could
confuse users. Would it make sense to unify these to a single field name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
