dawidwys commented on PR #27602:
URL: https://github.com/apache/flink/pull/27602#issuecomment-3932482275

   > Meta remark:
   During our previous discussions around SinkUpsertMaterializer, my 
understanding was that we'll implement compaction on watermark on top of the 
existing implementation (be it sum v1 or v2).
   I'm fine with adding a 3rd one, but I must say it complicates not only the 
code, but also the operations for the user.
   
   First time that I hear that. I can't find any such comments on the FLIP 
discussion. Moreover I can't think how that could be possible since we're 
changing the semantics slightly. Lastly adding watermark compaction to the 
existing SUM would not help with the state size. It still needs to keep the 
entire history.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to