davidradl commented on code in PR #27638:
URL: https://github.com/apache/flink/pull/27638#discussion_r2833011910
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java:
##########
@@ -781,6 +782,13 @@ public void updateCurrentEffectiveWatermark(long
watermark) {
public void updateCurrentSplitWatermark(String splitId, long watermark) {
WatermarkSampler splitWatermarkSampler =
checkNotNull(sampledSplitWatermarks.get(splitId));
splitWatermarkSampler.addLatest(watermark);
+ if (!currentlyIdleSplits.contains(splitId)) {
+ maybePauseSplit(splitId);
+ }
+ }
+
+ private void maybePauseSplit(String splitId) {
Review Comment:
the method name is strange - I was expecting it to start with e a verb like
the other methods. Maybe `updateCurrentSplitPausedWatermark
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java:
##########
@@ -781,6 +782,13 @@ public void updateCurrentEffectiveWatermark(long
watermark) {
public void updateCurrentSplitWatermark(String splitId, long watermark) {
WatermarkSampler splitWatermarkSampler =
checkNotNull(sampledSplitWatermarks.get(splitId));
splitWatermarkSampler.addLatest(watermark);
+ if (!currentlyIdleSplits.contains(splitId)) {
+ maybePauseSplit(splitId);
+ }
+ }
+
+ private void maybePauseSplit(String splitId) {
Review Comment:
the method name is strange - I was expecting it to start with a verb like
the other methods. Maybe `updateCurrentSplitPausedWatermark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
