gustavodemorais commented on code in PR #27508:
URL: https://github.com/apache/flink/pull/27508#discussion_r2848391158
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/keyselector/AttributeBasedJoinKeyExtractor.java:
##########
@@ -288,11 +311,13 @@ private RowData buildKeyRowFromJoinedRow(
for (int i = 0; i < keyExtractors.size(); i++) {
keyRow.setField(i,
keyExtractors.get(i).getLeftSideKey(joinedRowData));
}
- return keyRow;
+ return keySerializer.toBinaryRow(keyRow).copy();
Review Comment:
I like that we do a bit less with this. However, I don't like that we're
partially replicating a code that we have in RowDataSerializer. To pursue this
strategy, we could consider adding a `shouldReuseRow` flag to
RowDataSerializer. What do you think @twalthr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
